select_bit: Extract 32-bit non-SSE2 version #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract the 32-bit non-SSE2 select_bit implementation from BitVector::select0 and select1. This makes the code more regular, as 32-bit SSE2 and non-SSE2 can now be handled without an ifdef in select0/1. Having this function will also make PR28 cleaner. I benchmarked select0 and select1 with this commit on x86_64 with MARISA_WORD_SIZE defined to 32, and there is no measurable difference. This is not surprising, as unit_hi and unit_lo are in the same cache line.
Owner
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the 32-bit non-SSE2 select_bit implementation from
BitVector::select0andselect1.This makes the code more regular, as 32-bit SSE2 and non-SSE2
can now be handled without an
ifdefinselect0/1.Having this function will also make #28 cleaner.
I benchmarked
select0andselect1with this commit on x86_64 withMARISA_WORD_SIZEdefined to 32, and there is no measurable difference.This is not surprising, as unit_hi and unit_lo are in the same cache line.