Add CStr16::from_str_with_buf
#291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides an easy way to convert from a UTF-8 str to a CStr16 without requiring allocation. You just have to provide a backing buffer large enough to store the converted characters. Also converted the runtime vars test to use this method instead of `CString16`, since if the runtime tests are ever moved to run after exiting boot services, they won't be able to use allocation.
nicholasbishop
force-pushed
the
bishop-from-str-with-buf-2
branch
from
924244f to
1e3a74a
Compare
GabrielMajeri
approved these changes
Nov 27, 2021
Collaborator
GabrielMajeri
left a comment
GabrielMajeri
left a comment
There was a problem hiding this comment.
Looks great, thanks!
GabrielMajeri
changed the title
CStr16::from_str_with_buf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides an easy way to convert from a UTF-8 str to a CStr16
without requiring allocation. You just have to provide a backing buffer
large enough to store the converted characters.
Also converted the runtime vars test to use this method instead of
CString16, since if the runtime tests are ever moved to run afterexiting boot services, they won't be able to use allocation.