GameActivity-4.0.0: add set_ime_editor_info #200
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are going to use a submodule so that it is easier to track and rebase our local changes onto new versions of android-games-sdk Signed-off-by: William Casarin <[email protected]>
Also includes our patches on top (branch android-activity-2.0.2). This is mainly to test to make sure everything is still working. We will switch to the android-activity-4.0.0 branch when we're done Signed-off-by: William Casarin <[email protected]>
Signed-off-by: William Casarin <[email protected]>
This replaces `copy-files` + `file_list.txt` (subjective simplification) This imports the SDK from commit 1b544f896646b29e798c5be0a151a488906797f7, from: https://github.com/rust-mobile/android-games-sdk/commits/android-activity-4.0.0
Signed-off-by: William Casarin <[email protected]>
For convenience, when updating to new GameActivity versions, this makes it possible to build against the out-of-tree `android-games-sdk` repo. This also updates `generate-bindings.sh` to point at $ANDROID_GAMES_SDK if set. E.g. ``` git clone [email protected]:rust-mobile/android-games-sdk.git \ --branch android-activity-4.0.0 export ANDROID_GAMES_SDK=$PWD/android-games-sdk ./generate-bindings.sh cargo build --features=game-activity --target=aarch64-linux-android ```
Update the notes on how to update to new GameActivity releases
This corresponds to the GameActivity_setImeEditorInfo function on GameActivity. This is not supported on NativeActivity. Signed-off-by: William Casarin <[email protected]>
jb55
added a commit
to damus-io/notedeck
that referenced
this pull request
Jun 30, 2025
- android-activity: rust-mobile/android-activity#200 - winit: damus-io/winit@eaff639 - egui: damus-io/egui@113922d Signed-off-by: William Casarin <[email protected]>
jb55
added a commit
to damus-io/notedeck
that referenced
this pull request
Jun 30, 2025
support multiline ime hints --------------------------- - android-activity: rust-mobile/android-activity#200 - winit: damus-io/winit@eaff639 - egui: damus-io/egui@113922d And many other fixes -------------------- Fixes: #894 Fixes: #895 Fixes: #893 Signed-off-by: William Casarin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of:
The commit in this PR is:
This adds support for
GameActivity_setImeEditorInfowhich is needed for setting various IME hints, such as multiline.I'm currently using this in my egui/winit fork for mapping a new Multiline ImePurpose to ime editor options:
This ensures that the enter action button doesn't close the keyboard, it instead enters a newline.