[linfa-svm] Fix SVR nu parameter passing and rework SVR parameterization API #370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes and clarifies the SVR parameterization with regards to the original libsvm code
before:
nu_eps(nu, eps)
was wrongly wired:eps
was used fornu
andnu
forc
c_eps(c, eps)
is confusing: eps refers is epsilon of the inner loss function while there is also an epsilon used for the solverafter:
nu_svr(nu, Option<c>)
replaces deprecatednu_eps()
, optional parameter default is 1. as in libsvmc_svr(c, Option<loss_eps>)
replaces deprecatedc_eps()
second optional parameter default is 0.1 as in libsvmepsilon
of the solver is set throughSolverParams::epsilon()
as beforelinfa-svm
version to 0.7.2Fixes #317