Adding the x86 part of behavioural testing for std::arch intrinsics #1814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhav-madhusoodanan
force-pushed
the
x86_extension_intrinsic_test
branch
3 times, most recently
from
b2777ac to
7047369
Compare
Comment on lines
49
to
60
| match self { | ||
| Self::BFloat => "bfloat", | ||
| Self::Float => "float", | ||
| Self::Int => "int", | ||
| Self::UInt => "uint", | ||
| Self::Double => "double", | ||
| Self::Int(true) => "int", | ||
| Self::Int(false) => "uint", | ||
| Self::Poly => "poly", | ||
| Self::Void => "void", | ||
| Self::Char(true) => "char", | ||
| Self::Char(false) => "unsigned char", | ||
| Self::Short(true) => "short", | ||
| Self::Short(false) => "unsigned short", |
There was a problem hiding this comment.
@Amanieu @adamgemmell Are we using this trait (fmt::Display for TypeKind) anywhere in the crate? I was searching for its usage and I was unable to find any.
If we are not using this trait, may I delete the definition?
There was a problem hiding this comment.
I suspect this may be useful for debug output during development. However since it isn't used for functionality then it's fine to make any changes you want to it.
There was a problem hiding this comment.
Got it.
|
Pardon the git history, I will be sorting that out shortly |
madhav-madhusoodanan
force-pushed
the
x86_extension_intrinsic_test
branch
5 times, most recently
from
ed8dfde to
e6ff768
Compare
Amanieu
reviewed
Jun 18, 2025
| UInt, | ||
|
|
||
| // if signed, then the inner value is true | ||
| Int(bool), |
There was a problem hiding this comment.
Rather than using a bool, considering instead something like:
enum Signed {
Signed,
Unsigned,
}This ends up making the code much more readable.
| format!( | ||
| "\ | ||
| {line_prefix}This is a transient test file, not intended for distribution. Some aspects of the | ||
| {line_prefix}test are derived from a JSON specification, published under the same license as the |
There was a problem hiding this comment.
x86 uses an XML specification, not JSON.
trait to make the same dyn-compatible.
intrinsic-test's X86IntrinsicType struct
IntrinsicType impl
1. filtered any intrinsic arguments where the only parameter is of type "void" 2. Better parsing for intrinsic return type 3. Filtering intrinsics that are difficult to test (void returns) 4. Reduced the variants in TypeKind (which differed only in bit_len)
necessary. Further notes: 1. IntrinsicType.target -> IntrinsicType.metadata 2. Maintaining a HashMap to support arbitrary data storage for other arch
…ectly instead of constructing it. Further details: 1. moved "type_and_name_from_c" from Argument<T> to Argument<ArmIntrinsicType> 2. removed "from_c" in Argument<T>
madhav-madhusoodanan
force-pushed
the
x86_extension_intrinsic_test
branch
from
470a900 to
e113a61
Compare
madhav-madhusoodanan
force-pushed
the
x86_extension_intrinsic_test
branch
from
e113a61 to
bc5da7d
Compare
|
The CI is giving me an odd error, even after I rebased from master: Updating crates.io index
Locking 5 packages to latest compatible versions
Adding quick-xml v0.37.5
Adding serde-xml-rs v0.8.1
Adding thiserror v1.0.69
Adding thiserror-impl v1.0.69
Adding xml-rs v0.8.26
Compiling core_arch v0.1.5 (/Users/runner/work/stdarch/stdarch/crates/core_arch)
error: the feature `generic_arg_infer` has been stable since 1.89.0-nightly and no longer requires an attribute to enable
--> crates/core_arch/src/lib.rs:34:5
|
34 | generic_arg_infer,
| ^^^^^^^^^^^^^^^^^
|
= note: `-D stable-features` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(stable_features)]` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.