Skip to content

Arc make_mut doc comment spelling correction. #97603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2022
Merged

Arc make_mut doc comment spelling correction. #97603

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b54b91
Spelling correction.
ximon18 May 31, 2022
31ece0c
Update sync.rs
Dylan-DPC Jun 1, 2022
f81269f
Update sync.rs
Dylan-DPC Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion library/alloc/src/sync.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1397,7 +1397,7 @@ impl<T: Clone> Arc<T> {
/// be cloned.
///
/// See also [`get_mut`], which will fail rather than cloning the inner value
/// or diassociating [`Weak`] pointers.
/// or disassociating [`Weak`] pointers.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be dissociating?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paragraph above also says "disassociated" so this change would be consistent with that. From Googling I see that the two terms are synonyms having the same meaning and also being about the same age. Personally I don't use "dissociate" but instead use "disassociate", perhaps that's just what I grew up with in England, I assumed, wrongly it seems, that "dissociate" was American English

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh well, today both learned. I didn't know they meant the same thing or that "disassociate" existed ("disassociate" is actually closer to french so makes more sense to me ;) ).

///
/// [`clone`]: Clone::clone
/// [`get_mut`]: Arc::get_mut
Expand Down