-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Add long explanation for E0757 #87342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
A function was given both the `ffi_const` and `ffi_pure` attributes. | ||
|
||
Erroneous code example: | ||
|
||
```compile_fail,E0757 | ||
#![feature(ffi_const, ffi_pure)] | ||
|
||
extern "C" { | ||
#[ffi_const] | ||
#[ffi_pure] // error: `#[ffi_const]` function cannot be `#[ffi_pure]` | ||
pub fn square(num: i32) -> i32; | ||
} | ||
``` | ||
|
||
As `const` has a stricter set of requirements than `pure`, remove the `ffi_pure` | ||
attribute: | ||
|
||
``` | ||
#![feature(ffi_const)] | ||
|
||
extern "C" { | ||
#[ffi_const] | ||
pub fn square(num: i32) -> i32; | ||
} | ||
``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ffi_const
you mean? Also, is there a documentation we could link to by any chance?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I mean
const
.const
andpure
are C function attributes (e.g. see Common Function Attributes). Annotating a function withffi_const
says that it's Cconst
, and annotating withffi_pure
says that it's Cpure
. I could useffi_const
andffi_pure
instead, but I felt it was more readable to lift the covers up to what they mean in GCC or other C compilers. What do you think?I could link to ffi-pure and ffi-const from the unstable rust book. The former does mention that
#[ffi_const]
provides stronger guarantees, which implies that it's stricter.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use
ffi_*
instead then. If I asked the questions, others will wonder about the same thing as well. Please add the links as well then.