Skip to content

Fix #18604: next_power_of_two should panic on overflow #45754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 3 commits into from
Nov 5, 2017
Merged

Fix #18604: next_power_of_two should panic on overflow #45754

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15ea3d8
Fix #18604: next_power_of_two should panic on overflow
scottmcm Nov 4, 2017
1b19e64
Add overflow tests for next_power_of_two
scottmcm Nov 4, 2017
0d745af
Use Add::add for overflow checks instead of [rustc_inherit_overflow_c…
scottmcm Nov 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libcore/num/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2222,6 +2222,7 @@ macro_rules! uint_impl {
/// ```
#[stable(feature = "rust1", since = "1.0.0")]
#[inline]
#[rustc_inherit_overflow_checks]
pub fn next_power_of_two(self) -> Self {
self.one_less_than_next_power_of_two() + 1
}
Expand Down