Skip to content

Suggesting a change to a comment that puzzled me #36711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 2 commits into from
Sep 30, 2016
Merged

Suggesting a change to a comment that puzzled me #36711

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a72b4d
Suggesting a change to a comment that puzzled me
pcn Sep 25, 2016
c30eb31
Use "through"
pcn Sep 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/doc/book/references-and-borrowing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ fn main() {
return v.iter().fold(0, |a, &b| a + b);
}
// Borrow two vectors and sum them.
// This kind of borrowing does not allow mutation to the borrowed.
// This kind of borrowing does not allow mutation to the borrowed reference.
Copy link
Contributor

@bluss bluss Sep 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"the borrowed" refers to the vector (or vectors), not to the reference. What could be said is "does not allow mutation through the borrowed reference".

Copy link
Contributor

@bluss bluss Sep 25, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or just "does not allow mutation of the borrowed vectors." (?)

Copy link
Contributor Author

@pcn pcn Sep 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like "through" I think it helps me understand better.

fn foo(v1: &Vec<i32>, v2: &Vec<i32>) -> i32 {
// do stuff with v1 and v2
let s1 = sum_vec(v1);
Expand Down