Skip to content

Conversation

@steveklabnik
Copy link
Contributor

Fixes #19315

r? @aturon

@steveklabnik steveklabnik changed the title Import https://github.com/rust-lang/rust-guidelines/commit/16fa41b3b091e... Import rust-guidelines Feb 15, 2015
@aturon
Copy link
Contributor

aturon commented Feb 16, 2015

Awesome!

One question: I've never been overly fond of "Rust Guidelines" for the title of this, although now that the "Guides" are not a thing it's a little better. Any bikeshedding ideas?

@steveklabnik
Copy link
Contributor Author

PEP 8 is called "Style guide for python code". So "Style Guide"?

@aturon
Copy link
Contributor

aturon commented Feb 16, 2015

OK, sounds fine to me. Would you be willing to do the rename now, before we bring it in?

@steveklabnik
Copy link
Contributor Author

@aturon done, I think. 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could probably be left out

@steveklabnik
Copy link
Contributor Author

@alexcrichton nice, thanks! Fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

er I meant could this whole file be remove?

@alexcrichton
Copy link
Member

r=me with one small nit

I noticed that this is not actually linked from any location, but I think that's a good thing for now. We should take some more time to flesh out these documents before we're ready to link to them from the main page.

@steveklabnik
Copy link
Contributor Author

re links: exactly

@steveklabnik
Copy link
Contributor Author

@bors: r=alexcrichton 01c5208 rollup

@steveklabnik
Copy link
Contributor Author

re links: exactly what i was thinking.

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Feb 18, 2015
@huonw huonw merged commit 01c5208 into rust-lang:master Feb 18, 2015
@edunham edunham mentioned this pull request May 26, 2015
65 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish guidelines somewhere official

4 participants