Skip to content

Starting to de-glob std #18220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

mikedilger
Copy link
Contributor

This #11983 looked idle. Could someone check if I'm going about this in the right way? @brson @alexcrichton

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

@mikedilger
Copy link
Contributor Author

I should probably put spaces after the commas.

Is it ok to still be referencing prelude (as in this pull request), or should I use from where things are defined?

@alexcrichton
Copy link
Member

Thanks for taking a look at this @mikedilger! I think though that the issue is quite old at this point, and it's possible that we're going to have globs as part of the language proper for 1.0 rather than removing them.

It does seem that the readability of the imports decreases with this sort of rewrite to not use globs, so we may want to hold off on this for now. Would you be ok with that?

@mikedilger
Copy link
Contributor Author

Yes thanks @alexcrichton for stopping me before I went too far.

@mikedilger mikedilger closed this Oct 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants