Port several trait/coherence-related attributes the new attribute system #143403
+299
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-attributes
|
Some changes occurred in compiler/rustc_attr_parsing Some changes occurred in compiler/rustc_attr_data_structures Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
|
@rustbot blocked |
rustbot
added
S-blocked
|
☔ The latest upstream changes (presumably #143434) made this pull request unmergeable. Please resolve the merge conflicts. |
GrigorenkoPV
force-pushed
the
attributes/traits
branch
from
3ffba3f to
5e883ef
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
☔ The latest upstream changes (presumably #143459) made this pull request unmergeable. Please resolve the merge conflicts. |
GrigorenkoPV
force-pushed
the
attributes/traits
branch
from
5e883ef to
7acc628
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #131229
This ports:
#[const_trait]#[rustc_deny_explicit_impl]#[rustc_do_not_implement_via_object]#[rustc_coinductive]#[type_const]#[rustc_specialization_trait]#[rustc_unsafe_specialization_marker]#[marker]#[fundamental]#[rustc_paren_sugar]#[rustc_allow_incoherent_impl]#[rustc_coherence_is_core]This also changes
#[marker]to error on duplicates instead of warning.cc #142838, but I don't think it matters too much, since it's unstable.
r? @oli-obk