Remove PointerLike trait
#143308
Merged
Remove PointerLike trait
#143308
+14
−288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
compiler-errors
commented
Jul 2, 2025
| // currently use pseudo-canonical queries in the trait solver which replaces params with | ||
| // placeholders. We should also simply not use pseudo-canonical queries in the trait | ||
| // solver, at which point we can readd this assert. As of writing this comment, this is | ||
| // only used by `fn layout_is_pointer_like` when calling `layout_of`. |
There was a problem hiding this comment.
This isn't true :)
|
@rustbot author |
rustbot
added
S-waiting-on-author
|
Is there context for this change? |
|
removal of |
|
Not needed anymore lol |
|
Specifically, in #143036 (comment) I mentioned removing the |
compiler-errors
force-pushed
the
no-pointer-like
branch
from
8616eff to
e2e3f58
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 4, 2025
Rollup of 7 pull requests Successful merges: - #140643 (Refactor StableMIR) - #143286 (Make -Ztrack-diagnostics emit like a note) - #143308 (Remove `PointerLike` trait) - #143387 (Make __rust_alloc_error_handler_should_panic a function) - #143400 (Port `#[rustc_pass_by_value]` to the new attribute system) - #143417 (bump termize dep) - #143420 (rustc-dev-guide subtree update) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jul 4, 2025
Rollup merge of #143308 - compiler-errors:no-pointer-like, r=oli-obk Remove `PointerLike` trait r? oli-obk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? oli-obk