Skip to content

tests/ui: A New Order [9/N] #142214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2025
Merged

tests/ui: A New Order [9/N] #142214

merged 1 commit into from
Jun 29, 2025

Conversation

Kivooeo
Copy link
Contributor

@Kivooeo Kivooeo commented Jun 8, 2025 •
edited by jieyouxu
Loading

Some tests/ui/ housekeeping, to trim down number of tests directly under tests/ui/. Part of #133895.

@rustbot
Copy link
Collaborator

rustbot commented Jun 8, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 8, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kivooeo Kivooeo mentioned this pull request Jun 11, 2025
Merged
@jieyouxu
Copy link
Member

r? jieyouxu

@rustbot rustbot assigned jieyouxu and unassigned davidtwco Jun 11, 2025
jieyouxu
jieyouxu requested changes Jun 28, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one nit, please squash after and I'll r+

tests/ui/allocator/empty-alloc-nonnull-guarantee.rs Outdated
Comment on lines 3 to 5
//! This test ensures that Rust's allocator maintains the invariant that
//! Box<T> is always non-null, even for zero-sized types and empty allocations.
//! This is crucial for memory safety guarantees in Rust.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this guarantee is overly strong for what this test actually does, it's more like

Check that the default global Rust allocator in combination with Box produces a non-null allocation even when the contained type is zero-sized.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 28, 2025

⚠️ Warning ⚠️

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kivooeo
Copy link
Contributor Author

Kivooeo commented Jun 28, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 28, 2025
@jieyouxu
Copy link
Member

Thanks
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 29, 2025

📌 Commit f4502b8 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2025
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 29, 2025
Merged
bors added a commit that referenced this pull request Jun 29, 2025
@bors
Auto merge of #143183 - GuillaumeGomez:rollup-g60lr91, r=GuillaumeGomez
5e749eb 
Rollup of 4 pull requests

Successful merges:

 - #142078 (Add SIMD funnel shift and round-to-even intrinsics)
 - #142214 (`tests/ui`: A New Order [9/N])
 - #142417 (`tests/ui`: A New Order [12/N])
 - #143030 (Fix suggestion spans inside macros for the `unused_must_use` lint)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 15b227f into rust-lang:master Jun 29, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jun 29, 2025
rust-timer added a commit that referenced this pull request Jun 29, 2025
@rust-timer
Unrolled build for #142214
5447f1e 
Rollup merge of #142214 - Kivooeo:tf9, r=jieyouxu

`tests/ui`: A New Order [9/N]

Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of #133895.
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Jun 29, 2025
@bors
Auto merge of #143183 - GuillaumeGomez:rollup-g60lr91, r=GuillaumeGomez
b47132d 
Rollup of 4 pull requests

Successful merges:

 - rust-lang/rust#142078 (Add SIMD funnel shift and round-to-even intrinsics)
 - rust-lang/rust#142214 (`tests/ui`: A New Order [9/N])
 - rust-lang/rust#142417 (`tests/ui`: A New Order [12/N])
 - rust-lang/rust#143030 (Fix suggestion spans inside macros for the `unused_must_use` lint)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Kivooeo @rustbot @rust-log-analyzer @jieyouxu @bors @davidtwco