Skip to content

ci: test cargo on aarch64-gnu #123828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2024
Merged

ci: test cargo on aarch64-gnu #123828

merged 2 commits into from
Apr 15, 2024

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Apr 11, 2024

Since aarch64-unknown-linux-gnu is a tier-1 target, we should also test cargo on it, especially since cargo's own CI doesn't cover this yet. This might have helped us discover #123733 sooner, which is not a cargo problem but was uncovered by a new cargo test (which we'll have to skip for now). Everything else passes in my local run, so at least we'll have a guard against future regressions.

@rustbot
Copy link
Collaborator

rustbot commented Apr 11, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Apr 11, 2024
@cuviper cuviper force-pushed the cargo-aarch64-gnu branch from 91d035e to 814c196 Compare April 11, 2024 23:48
@cuviper
Copy link
Member Author

cuviper commented Apr 11, 2024

Dropped cargotest, as suggested on zulip.

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=iffy

@bors
Copy link
Collaborator

bors commented Apr 13, 2024

📌 Commit 814c196 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 14, 2024
@bors
Auto merge of rust-lang#123828 - cuviper:cargo-aarch64-gnu, r=Mark-Si…
9678dac 
…mulacrum

ci: test cargo on `aarch64-gnu`

Since `aarch64-unknown-linux-gnu` is a tier-1 target, we should also test cargo on it, especially since cargo's own CI doesn't cover this yet. This might have helped us discover rust-lang#123733 sooner, which is not a cargo problem but was uncovered by a new cargo test (which we'll have to skip for now). Everything else passes in my local run, so at least we'll have a guard against future regressions.
@bors
Copy link
Collaborator

bors commented Apr 14, 2024

⌛ Testing commit 814c196 with merge 9678dac...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Apr 14, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 14, 2024
ehuss
ehuss reviewed Apr 14, 2024
View reviewed changes
@cuviper
Copy link
Member Author

cuviper commented Apr 14, 2024

@bors r=Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Apr 14, 2024

📌 Commit 2970ae5 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2024
@bors
Copy link
Collaborator

bors commented Apr 15, 2024

⌛ Testing commit 2970ae5 with merge 1d8f4a6...

@bors
Copy link
Collaborator

bors commented Apr 15, 2024

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 1d8f4a6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 15, 2024
@bors bors merged commit 1d8f4a6 into rust-lang:master Apr 15, 2024
@rustbot rustbot added this to the 1.79.0 milestone Apr 15, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1d8f4a6): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.7% [1.7%, 1.7%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.9% [-0.9%, -0.9%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 675.963s -> 677.574s (0.24%)
Artifact size: 316.01 MiB -> 315.94 MiB (-0.02%)

@cuviper cuviper deleted the cargo-aarch64-gnu branch April 21, 2024 18:28
@Enselic Enselic mentioned this pull request Jun 22, 2025
Merged
rust-bors bot added a commit that referenced this pull request Jul 1, 2025
@rust-bors
Auto merge of #142886 - Enselic:aarch64-panic, r=<try>
17493df 
ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`

The skipped test passes since `nightly-2024-11-29`. See #123733 (comment) and #123733 (comment) for more info.

Let's stop skipping it to increase the chance of detecting a regression.

r? `@cuviper` who added the skip in #123828

Also see #142304 for an alternative regression test that I am hoping to also land in the near future to complement the test we now stop skipping, but I need to investigate that setup more.

<!-- homu-ignore:start -->
<!--
If this PR is related to an unstable feature or an otherwise tracked effort,
please link to the relevant tracking issue here. If you don't know of a related
tracking issue or there are none, feel free to ignore this.

This PR will get automatically assigned to a reviewer. In case you would like
a specific user to review your work, you can assign it to them by using

    r? <reviewer name>
-->
<!-- homu-ignore:end -->

try-job: aarch64-gnu
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 1, 2025
@jhpratt
Rollup merge of rust-lang#142886 - Enselic:aarch64-panic, r=cuviper
f7231b3 
ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`

The skipped test passes since `nightly-2024-11-29`. See rust-lang#123733 (comment) and rust-lang#123733 (comment) for more info.

Let's stop skipping it to increase the chance of detecting a regression.

r? `@cuviper` who added the skip in rust-lang#123828

Also see rust-lang#142304 for an alternative regression test that I am hoping to also land in the near future to complement the test we now stop skipping, but I need to investigate that setup more.
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 2, 2025
@jhpratt
Rollup merge of rust-lang#142886 - Enselic:aarch64-panic, r=cuviper
ebd37e3 
ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`

The skipped test passes since `nightly-2024-11-29`. See rust-lang#123733 (comment) and rust-lang#123733 (comment) for more info.

Let's stop skipping it to increase the chance of detecting a regression.

r? ``@cuviper`` who added the skip in rust-lang#123828

Also see rust-lang#142304 for an alternative regression test that I am hoping to also land in the near future to complement the test we now stop skipping, but I need to investigate that setup more.
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 2, 2025
@jhpratt
Rollup merge of rust-lang#142886 - Enselic:aarch64-panic, r=cuviper
31c6a20 
ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`

The skipped test passes since `nightly-2024-11-29`. See rust-lang#123733 (comment) and rust-lang#123733 (comment) for more info.

Let's stop skipping it to increase the chance of detecting a regression.

r? ```@cuviper``` who added the skip in rust-lang#123828

Also see rust-lang#142304 for an alternative regression test that I am hoping to also land in the near future to complement the test we now stop skipping, but I need to investigate that setup more.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 2, 2025
@matthiaskrgr
Rollup merge of rust-lang#142886 - Enselic:aarch64-panic, r=cuviper
7a406f1 
ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`

The skipped test passes since `nightly-2024-11-29`. See rust-lang#123733 (comment) and rust-lang#123733 (comment) for more info.

Let's stop skipping it to increase the chance of detecting a regression.

r? ````@cuviper```` who added the skip in rust-lang#123828

Also see rust-lang#142304 for an alternative regression test that I am hoping to also land in the near future to complement the test we now stop skipping, but I need to investigate that setup more.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 2, 2025
@matthiaskrgr
Rollup merge of rust-lang#142886 - Enselic:aarch64-panic, r=cuviper
7532d5f 
ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`

The skipped test passes since `nightly-2024-11-29`. See rust-lang#123733 (comment) and rust-lang#123733 (comment) for more info.

Let's stop skipping it to increase the chance of detecting a regression.

r? `````@cuviper````` who added the skip in rust-lang#123828

Also see rust-lang#142304 for an alternative regression test that I am hoping to also land in the near future to complement the test we now stop skipping, but I need to investigate that setup more.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 2, 2025
@matthiaskrgr
Rollup merge of rust-lang#142886 - Enselic:aarch64-panic, r=cuviper
453a2a9 
ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`

The skipped test passes since `nightly-2024-11-29`. See rust-lang#123733 (comment) and rust-lang#123733 (comment) for more info.

Let's stop skipping it to increase the chance of detecting a regression.

r? ``````@cuviper`````` who added the skip in rust-lang#123828

Also see rust-lang#142304 for an alternative regression test that I am hoping to also land in the near future to complement the test we now stop skipping, but I need to investigate that setup more.
rust-timer added a commit that referenced this pull request Jul 2, 2025
@rust-timer
Unrolled build for #142886
35585f4 
Rollup merge of #142886 - Enselic:aarch64-panic, r=cuviper

ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`

The skipped test passes since `nightly-2024-11-29`. See #123733 (comment) and #123733 (comment) for more info.

Let's stop skipping it to increase the chance of detecting a regression.

r? ``````@cuviper`````` who added the skip in #123828

Also see #142304 for an alternative regression test that I am hoping to also land in the near future to complement the test we now stop skipping, but I need to investigate that setup more.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
7 participants
@cuviper @rustbot @Mark-Simulacrum @bors @rust-log-analyzer @rust-timer @ehuss