Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows,
shutdowndoes not interruptread, even though we document that it does (see #121594).The
close_read_wakes_uptest has a race condition and only passes on windows if theshutdownhappens before theread. This PR ignores the test on windows adds a sleep to make it more likely that thereadhappens before theshutdownand the test actually tests what it is supposed to test on other platforms.I'm submitting this before any docs changes, so that we can find out on what platforms
shutdownactually works as documented.r? @ChrisDenton