Skip to content

Make AIX known by bootstrap #115811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 4 commits into from
Sep 18, 2023
+8 −0
Merged

Make AIX known by bootstrap #115811

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2962528
Make AIX known by bootstrap
Sep 13, 2023
fc17e09
Add comment to elaborate
Sep 13, 2023
5049a71
Adjust comment
Sep 13, 2023
122d1cc
Adjust comment
Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/bootstrap/bootstrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,8 @@ def default_build_triple(verbose):
# non-standard string (e.g. gnuwin32 tools returns `windows32`). In
# these cases, fall back to using sys.platform.
return 'x86_64-pc-windows-msvc'
elif kernel == 'AIX':
Copy link
Member

@Noratrieb Noratrieb Sep 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make more sense to add AIX to the kerneltype map above?

Copy link
Contributor Author

@bzEq bzEq Sep 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added comment to describe the reason :).

return 'powerpc64-ibm-aix'
else:
err = "unknown OS type: {}".format(kernel)
sys.exit(err)
Expand Down