Consistent tiers target naming #902
Open
+11
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
jieyouxu
reviewed
Jun 16, 2025
Comment on lines
+21
to
+22
| - A Final Comment Period is started by a T-compiler member, it's a tool to get concrete consensus | ||
| from the team. |
There was a problem hiding this comment.
Remark: there's a funny thing where "FCP" can mean both:
- A
compiler-fcpteam consensus vote, which is a full FCP-subteam Final Comment Period. - A Major Change Proposal (MCP) acceptance Final Comment Period window, but that only requires one "second" and no blocking objections.
Lol.
There was a problem hiding this comment.
uhhh
Let's pretend you didn't see anything.
apiraino
changed the title
|
I agree with switching to numerals, but I don't know about capitalizing it everywhere. The cited Platform Support page does not generally do that, only in titles and in links referencing those titles. |
|
Done (I'll squash before merging when there are no more comments - or opposing opinions to merge) |
apiraino
force-pushed
the
consistent-target-tier-naming
branch
from
fd9e6bd to
dfd152b
Compare
apiraino
force-pushed
the
consistent-target-tier-naming
branch
from
dfd152b to
fe8588e
Compare
tshepang
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may sound like incredible bikeshedding 😃 but I searched for "tier {1,2,3}" in the compiler proposals page and could not find matches. In my head I am used to identify them as I read in the Platform Support page (capitalized word followed by an arabic numeral)
Makes sense?
The second commit slightly clarifies what an FCP is, I'm not 100% sure it's a a widespread enough acronym to give it for granted.
Rendered