Switch to upstream positionEncoding
#13484
Conversation
crates/rust-analyzer/Cargo.toml
Outdated
| @@ -23,7 +23,7 @@ crossbeam-channel = "0.5.5" | |||
| dissimilar = "1.0.4" | |||
| itertools = "0.10.5" | |||
| scip = "0.1.1" | |||
| lsp-types = { version = "0.93.1", features = ["proposed"] } | |||
| lsp-types = { version = "0.93.2", features = ["proposed"] } | |||
There was a problem hiding this comment.
| lsp-types = { version = "0.93.2", features = ["proposed"] } | |
| lsp-types = { version = "=0.93.2", features = ["proposed"] } |
We might wanna pin our lsp-types version to prevent breakages like these in the future
There was a problem hiding this comment.
This was lsp-types breaking semver in a minor release, but sure, it can't hurt. I just hope we don't end up doing this for every dependency.
Or we could do ..Default::default().
There was a problem hiding this comment.
Oh for some reason I thought they were breaking by keeping versions numbers in sync, but thats not the case. Nevermind then, that's just unfortunate i guess
There was a problem hiding this comment.
It's fine to pin it, I think it's not the first time something like this happens. But if rather not use default() so that we know when something new gets added there.
There was a problem hiding this comment.
gluon-lang/lsp-types#248 (comment) so ye, pinning is the right choice for us here
|
@bors r+ |
|
@bors ping |
|
😪 I'm awake I'm awake |
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Closes #13481
This drops support for the custom extension, but that's probably fine.
Draft because it's not tested yet.