Skip to content

fix: Fix auto-ref completions inserting into wrong locations #12597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2022

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jun 20, 2022

Fixes #8058

@Veykril Veykril marked this pull request as ready for review June 20, 2022 18:23
@Veykril
Copy link
Member Author

Veykril commented Jun 20, 2022

Fixing this required way too much refactoring 😓
While this fixes the bug it doesn't yet close #12571, there is still quite some refactoring to do here, but we are getting closer!
@bors r+

@bors
Copy link
Contributor

bors commented Jun 20, 2022

📌 Commit 8b07898 has been approved by Veykril

@bors
Copy link
Contributor

bors commented Jun 20, 2022

⌛ Testing commit 8b07898 with merge 439a513...

@bors
Copy link
Contributor

bors commented Jun 20, 2022

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 439a513 to master...

@bors bors merged commit 439a513 into rust-lang:master Jun 20, 2022
@Veykril Veykril deleted the completions branch June 20, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reference completions for nested struct fields put & in wrong location
2 participants