Successively disabling and enabling inlay hints doesn't reliably work without typing a character

[x-hgg-x]

rust-analyzer version: rust-analyzer version: 65fbe0a 2022-04-18 stable

rustc version: rustc 1.60.0 (7737e0b5c 2022-04-04)

relevant settings: Vscode 1.66 on Linux

In the previous version of the extension, I could easily toogle inlay hints with the Rust Analyzer: Toggle inlay hints command.
Now, with the switch to LSP inlay hints, I cannot reenable inlay hints immediately after disabling it, and I need to type a character to "refresh" rust-analyzer.

In the following video, the inlay hints stop working at 0:06, then after I insert a space at 0:10, it works again at 0:12:

out.mp4

[lnicola]

I was ready to chalk this off as a Code bug (which is still possible), but the command works in a TypeScript file.

You can also notice how hints flash after being enabled.

[SE2Dev]

Toggle Inlay hints doesn't appear to respect "rust-analyzer.inlayHints.enable": false, in the latest update. My current workaround is to disable inlay hints for Rust entirely via:

"[rust]": {
   "editor.inlayHints.enabled": false
},

[lnicola]

There's no more rust-analyzer.inlayHints.enable in the latest update (which may or may not be available on the Code Marketplace due to unrelated reasons), Toggle inlay hints toggles editor.inlayHints.enabled instead.

[SE2Dev]

At the time of writing the latest version of the VSCode extension is v0.2.1022 (which was released yesterday). This version still includes rust-analyzer.inlayHints.enable in the settings schema - so it probably should be marked as deprecated, or removed entirely.

It may also be more desirable to change the Toggle inlay hints command to toggle editor.inlayHints.enabled only for Rust (like this), rather than affecting the inlay settings for all languages.

[lnicola]

@SE2Dev see #12037

[villem]

Hi,
The original problem still prevails. Toggling hints back shows hints after a something has been typed. I'm using rust-analyzer version: 1894473 2022-04-23 nightly.

[lnicola]

Not a fix for this, but the new version of Code is more flexible in this regard:

Editor › Inlay Hints: Enabled value:

on - Inlay hints are enabled.
off - Inlay hints are disabled.
onUnlessPressed - Inlay hints shown and hidden with Ctrl+Alt.
offUnlessPressed - Inlay hints hidden and shown with Ctrl+Alt.

[villem]

The new "OnUlessPressed" mode works perfectly for me. I'm fine if we close this issue.

[lnicola]

I'm worried that this is currently broken anyway, since it toggles between true and false, not on and off.