Followup on pruning unused files

[pietroalbini]

I tried doing a nightly release on dev-static with #21 (pruning unused files) enabled, and the feature is definitely not ready to be enabled in production. This issue tracks the work needed to make it production ready.

[pietroalbini]

The difference between the files uploaded by the current code in production and the files uploaded by the experimental code on dev is in this gist. To summarize (:green_square: intentional -- :orange_square: intentional but surprising -- :red_square: bug to fix):

• 🟩 The build-manifest component was removed.
• 🟩 The rust-dev component was removed.
• 🟩 The cpu-{builder}.csv files were removed.
• 🟩 The image-{builder}.txt files were removed.
• 🟩 The toolstates-{platform}.txt files were removed.
• 🟧 The miri component was removed.
  • Miri is failing toolstate, so it's being explicitly removed from the manifest.
  • We can expect the same of rust-analyzer for beta and stable releases, as it's nightly-only.
• 🟧 The rust-docs component was removed on multiple targets.
  • Affected targets: aarch64-apple-darwin, aarch64-apple-ios, aarch64-pc-windows-msvc, x86_64-apple-ios, i586-pc-windows-msvc
  • These targets do not have docs enabled in the manifest, as they're not Tier 1.
• 🟧 The i686-unknown-freebsd target was removed.
  • Dunno what's going on here, I need to investigate.
  • See Followup on pruning unused files #23 (comment)
• 🟥 The .pkg macOS installers were removed.
  • We need to whitelist this in promote-release, or address it as part of Include all shipped files in the manifest #22.
• 🟥 The .msi Windows installers were removed.
  • We need to whitelist this in promote-release, or address it as part of Include all shipped files in the manifest #22.

[pietroalbini]

Oh, wow, there is a reason why everything but rust-std for the i686-unknown-freebsd target was removed: we're running a full dist builder for it, but it's marked as target-only in build-manifest. We built full dist artifacts for it since literally forever, but we never made them usable through rustup 🤦

[pietroalbini]

The missing .pkg and .msi will be fixed by rust-lang/rust#78486.

[pietroalbini]

Did another run with the latest changes merged in, and the difference between the files uploaded by the current code in production and the files uploaded by the experimental code on dev is in this gist.

To summarize (:green_square: intentional -- :orange_square: intentional but surprising -- :red_square: bug to fix):

• 🟩 The build-manifest component was removed.
• 🟩 The rust-dev component was removed.
• 🟩 The cpu-{builder}.csv files were removed.
• 🟩 The image-{builder}.txt files were removed.
• 🟩 The toolstates-{platform}.txt files were removed.
• 🟧 The miri component was removed.
  • Miri is failing toolstate, so it's being explicitly removed from the manifest.
  • We can expect the same of rust-analyzer for beta and stable releases, as it's nightly-only.
• 🟧 The rust-docs component was removed on multiple targets.
  • Affected targets: aarch64-apple-darwin, aarch64-apple-ios, aarch64-pc-windows-msvc, x86_64-apple-ios, i586-pc-windows-msvc
  • These targets do not have docs enabled in the manifest, as they're not Tier 1.
• 🟧 The i686-unknown-freebsd target was removed.
  • See Followup on pruning unused files #23 (comment)

[pietroalbini]

The PR enabling this was just merged!