Skip to content

Conversation

AhoyISki
Copy link

I saw that some of the structs that are part of the Record didn't implement the Copy trait. Is there any reason for this? If there is, I guess you can ignore this pull request, but in my use case, it would be kind of useful to be able to copy a Record, especially considering that nothing inside of a Record precludes it from implementing Copy, since it's all just references inside.

@AhoyISki AhoyISki changed the title Is there any reason for some of these struct not to implement Copy? Is there any reason for some of these structs not to implement Copy? Jun 14, 2025
@KodrAus
Copy link
Contributor

KodrAus commented Jun 14, 2025

Thanks for the PR @AhoyISki. The main reason we haven't done this already would just be because it's a major API commitment that we wouldn't ever be able to back out of, and since the Log trait takes records by reference, there isn't a need in log's own API to copy records.

@AhoyISki
Copy link
Author

That's understandable, I guess.

@AhoyISki AhoyISki closed this Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants