Derive Copy for MatchOptions struct

[g-s-k]

MatchOptions contains 3 boolean values, which are Copy. It would be nice to be able to pass it by-value (rather than borrow it or create a new one on each function call).

Also included in this PR:

• Removed a compile warning due to a deprecated trait (::std::ascii::AsciiExt)
• Turned on clippy::pedantic and fixed all of its recommendations (don't worry, turned it off afterward)
• Turned off a test for macos that counts on a /root directory (my install does not have one)

[KodrAus]

Hi @g-s-k 👋

Thanks for taking the time to do some cleanup here. I'll just have to check that we haven't bumped the minimum version of rustc that's needed to build the library too far because of any clippy suggestions.

[g-s-k]

@KodrAus good point - please let me know if/how i can help with that.

[g-s-k]

hi @KodrAus - just wanted to bump this. I installed rust stable 1.24.0 (the current release the last time a PR was merged) and cargo test ran without any errors. Is there an earlier version you'd like me to test?

[g-s-k]

I've done a more thorough check now. Here's what I found:

• 1.23.0 and later compile and test successfully
• 1.17.0 through 1.22.0 require the AsciiExt trait to be in scope
• 1.14.0 through 1.16.0 require variable names that match struct field names to be repeated after the colon (foo: foo,)
• 1.13.0 requires a lifetime for const string slices
• 1.12.0 and earlier don't recognize the format of the Cargo.lock.

All but the last line indeed apply to this PR - how far back do you need to remain compatible?

[KodrAus]

@g-s-k Sorry for dropping the ball on this one, and thanks for checking this out!

1.23.0 is over 12 months old, so I think that's a reasonable minimum version to start supporting.

[KodrAus]

Thanks again for cleaning this up!

[g-s-k]

Happy to help!