ran cargo clippy --fix -- -Wclippy::use_self
#1165
Conversation
There was a problem hiding this comment.
What is the motivation of this PR?
There was a problem hiding this comment.
Are you taking about the default impl? Or the whole thing?
There was a problem hiding this comment.
This description of this PR is missing, which I was looking for.
There was a problem hiding this comment.
The purpose is to make the codebase idiomatic.
There was a problem hiding this comment.
Note that clippy::use_self is under the nursery lint group. I would not recommend enabling it at this moment.
Also, personally I am not sure it is more idiomatic or not. Sometimes I found it hard to understand the surrounding context because we don't have type name explicitly.
There was a problem hiding this comment.
Also, this adds lots of git diff / code churns.
There was a problem hiding this comment.
I did not enable it, I just ran it.
It is more idiomatic, explicit types require you to read the type to make sure it's the same.
There was a problem hiding this comment.
Good point.
Since the use_self lint introduces a lot of line changes, could you make it a separate commit to make other lint fix stand out? That helps the review of some lints get false positive fixes.
Also, one CI job is failing.
No description provided.