Better error reporting on invalid upload request #860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain what this commit does in the message, and why it improves the error reporting? (Probably mention the problem linked in that comment, and what the message is now) |
|
Sure, the problem is that after switching to serde we're returning custom serde error, for which debug implementation doesn't look nice. Solution to this problem is to use display (to_string) implementation instead of debug. with display: |
|
I'd love to see that in the commit message. 😄 |
Problem: after switching to serde we're returning custom serde error,
for which debug implementation doesn't look nice.
Solution: use display (to_string) when reporting an error
instead of debug.
example error message before:
`ErrorImpl { code: Message("invalid value: string \"name\", \
expected ERROR MESSAGE"), line: 0, column: 0 }`
after:
`invalid value: string "name", expected ERROR MESSAGE`
|
Love it, thank you!!! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comment.