Skip to content

fix: Expand error messages around path dependency on cargo package and cargo publish #15705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

motorailgun
Copy link
Contributor

fix #15607.

What does this PR try to resolve?

Current error message about path/git dependency being inside manifest on cargo package and cargo publish lacks some information and it can be confusing. This PR adds some context on which manifest error originates from, so that users can understand the exact cause of the error cargo reports.

@rustbot
Copy link
Collaborator

rustbot commented Jun 26, 2025

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-interacts-with-crates.io Area: interaction with registries Command-package Command-publish S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2025
@motorailgun motorailgun force-pushed the better-diagnosis-path-dependency branch from f0bb1cc to 8f4ae79 Compare June 26, 2025 02:54
Copy link
Contributor

@epage epage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@epage epage added this pull request to the merge queue Jun 26, 2025
Merged via the queue into rust-lang:master with commit 7388d86 Jun 26, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-interacts-with-crates.io Area: interaction with registries Command-package Command-publish S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing error when publishing a package with a path dependency without a version requirement
4 participants