Ensure --release examples are classified as benchmarks #1325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This puts them in the right spot of the dependency graph to be only available after all dev-dependencies have been compiled. Closes rust-lang#1323
|
r? @huonw |
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
r=me, but seems travis may have legitimately failed. |
|
Aha you are correct! That's what I get for just running the new test and not all the other tests. The underlying problem has been nagging at me for so long now (and I don't know of a nice fix for this), that I'm going to take some time to fix the underlying problem as well. Hopefully it won't take too too long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts them in the right spot of the dependency graph to be only available
after all dev-dependencies have been compiled.
Closes #1323