-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Chapter 15: Smart pointers #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
0d32bbe
Chapter 15: Smart pointers
steveklabnik 4ad2690
more work on smart pointers
steveklabnik ac61cbd
finish off draft
steveklabnik 01e407a
First editing pass
carols10cents 092ff98
Address most comments, make more notes
carols10cents 54e807c
A more thorough editing pass
carols10cents 12e12c8
More edits
carols10cents b07ce30
All but the summary
carols10cents 3af06ba
Whew. Finish editing.
carols10cents 5af5c49
Split into sections
carols10cents 8a39ec9
Connect Drop a bit more to Rc
carols10cents d2e6325
Multithreaded, one word, is in No Starch's style guide
carols10cents 8d784f7
Finish a sentence
carols10cents 334c10e
Wrap
carols10cents a251d43
Take awesome suggestions from @matthewjasper
carols10cents 3595078
Start (but not complete) swapping out the weak Weak<T> ex
carols10cents 61d552e
Clarify why we can't call Drop::drop
carols10cents 77f697b
Make section titles consistent and easier to scan
carols10cents 13b10e7
Rejigger intro
carols10cents aa03fa1
More rejiggering because of @ScottAbbey's excellent comments <3
carols10cents 6672fd6
Another attempt at the Weak<T> example
carols10cents bf02924
Set up example about borrowing rules on refcell better
carols10cents b460d00
Remove unnecessary sentence
carols10cents 5c6c1ab
Fix capitalization
carols10cents e4658ca
Remove File since it doesn't implement Deref
carols10cents c981fc0
Remove sentence about box being on the stack; not quite true
carols10cents 84255f9
Address most of aturon's comments
carols10cents 52d109f
Try to make examples a bit clearer
carols10cents 90c380c
Try to clarify that RefCell isn't really a smart pointer
carols10cents 72b4ceb
More RefCell clarification
carols10cents d7ade00
Clarify another instance of immutable data
carols10cents 6646733
Use a sillier example than the non-functioning WebSocket
carols10cents 90ba6d3
Incorporate the Weak example
carols10cents 542013a
See if we can get away with not editing chapter 4
carols10cents b13b292
Fixing spelling and tests
carols10cents 0e27654
Infinite type illustration
carols10cents a17e7ca
Add a diagram for Cons with Box
carols10cents 07310e5
Add more figures
carols10cents 87609b1
graphviz is terrible
carols10cents 5f6113d
wrong way arrow
carols10cents 3bfc407
halp can't get arrow pointing the way i want
carols10cents 364ff83
more diagrams
carols10cents File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is 'smart pointer' the right way refer to things in other languages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is in C++, and other similar kinds of languages, yeah