Ensure missing return fields from types structs are tested for #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few structs had a different order of the derives. These were missed in a search and replace for all structs that had `Serialize` and therefore `serde` when adding `#[serde(deny_unknown_fields)]`. Reorder the derives to be the same as everywhere else.
There was a blank line and then a comment after the derive. Fix it so that the comment is before the derive and there is no blank line.
Add `#[serde(deny_unknown_fields)]` to all structs in `types` that derive `Serialize` and therefore use serde. Using a search and replace.
tcharding
approved these changes
Jun 28, 2025
|
BOOM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are missing return fields in the types structs the integration tests still pass.
All of the missing fields have been added in #243, #251, #255, #267 and #272.
The solution suggested in issue #241 is adding
#[serde(deny_unknown_fields)]to each struct which makes the test fail if there are fields returned that are not in the struct.#[serde(deny_unknown_fields)]to all structs intypesthat deriveSerializeand therefore use serde. Using a search and replace.Closes #241