Implement encryptwallet method and test #250
Conversation
GideonBature
force-pushed
the
encryptwallet
branch
from
f473e1e to
e9bf939
Compare
|
Nice, you're on a roll. |
Thank you! |
integration_test/tests/wallet.rs
Outdated
| let client = match () { | ||
| #[cfg(feature = "v20_and_below")] | ||
| () => node.create_wallet(wallet_name).expect("createwallet"), | ||
| #[cfg(not(feature = "v20_and_below"))] | ||
| () => { | ||
| node.client.create_wallet(wallet_name).expect("createwallet"); | ||
| &node.client | ||
| }, |
There was a problem hiding this comment.
Are you feeling adventurous? It would be nice to investigate why this is needed and move the feature gating logic to node/src/lib.rs in the create_wallet function so that every test author does not have to think about it. FTR I did not investigate, I vaguely remember hitting this before though so my suggestion is just a hunch.
There was a problem hiding this comment.
True. I am even thinking that we can just use the create_wallet function from node, since it returns a client, then we can just call the encrypt_wallet on that client directly, I think it should work with all the versions, so we need not feature gate the test any more.
The create_wallet from node works for v17-v20 that needs the full wallet uri and for v21 upwards which also accepts either just the wallet name or the full wallet uri.
GideonBature
force-pushed
the
encryptwallet
branch
4 times, most recently
from
078e1f7 to
7e50e41
Compare
GideonBature
force-pushed
the
encryptwallet
branch
from
29a4a50 to
e513cbe
Compare
The JSON-RPC method
encryptwalletdoes return a type. We want to test this to catch any changes in behavior in future Core versions.This PR adds a client function that errors if the return value is anything other than the type it returns, along with an integration test that calls this function.
Ref: #116