Skip to content

Implement abandontransaction and test #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

GideonBature
Copy link
Contributor

The JSON-RPC method abandontransaction does return null. We want to test this to catch any changes in behavior in future Core versions.

This PR adds a client function that errors if the return value is anything other than null, along with an integration test that calls this function.

Ref: #116

Copy link
Collaborator

@jamillambert jamillambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5d6b977

Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5d6b977

@tcharding tcharding merged commit 37510f9 into rust-bitcoin:master Jun 9, 2025
29 checks passed
@tcharding
Copy link
Member

Clean, thanks.

@GideonBature
Copy link
Contributor Author

You are welcome.

@GideonBature GideonBature deleted the abandontransaction branch June 14, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants