Skip to content

Update 'returns (std)' to 'version' for version methods #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2025
Merged

Update 'returns (std)' to 'version' for version methods #217

merged 1 commit into from
May 31, 2025

Conversation

GideonBature
Copy link
Contributor

@GideonBature GideonBature commented May 30, 2025 •
edited
Loading

This PR updates returns (std) to version for all methods that have been implemented to return a type which wraps a standard value.

Ref: #116

tcharding
tcharding approved these changes May 31, 2025
View reviewed changes
Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e266b9f

@tcharding tcharding merged commit 4a26bee into rust-bitcoin:master May 31, 2025
29 checks passed
@tcharding
Copy link
Member

tcharding commented May 31, 2025 •
edited
Loading

Thanks for going back and getting them all.

@GideonBature
Copy link
Contributor Author

You are welcome. :).

@GideonBature GideonBature deleted the std-to-version branch May 31, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcharding tcharding tcharding approved these changes

Assignees
No one assigned
Labels
C-types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GideonBature @tcharding