Fix DRM resource leaks causing Kodi crashes and replace red init colour #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create main.yml
Added support for RGB565
Fix on Raspberry Pi 4
Small fixes to release workflow
Add support for NV12, P030 and linear decimation
- Detect 4K framebuffer resolution - Skip capture during 4K playback - Send warm ambient color instead - Automatically resume for HD content
Author
|
Don´t merge yet, I'll test it for a few days if it works as expectd. |
joopdo
force-pushed
the
feature/4k-detection-workaround
branch
2 times, most recently
from
e6925e7 to
fffd38c
Compare
added 2 commits
December 10, 2025 13:06
- Fix GEM handle cleanup in dump_framebuffer_to_image() - Clean up ALL GEM handles, not just handles[0] - Add duplicate handle detection to avoid cleanup warnings - Update deployment script for LibreELEC compatibility Resolves critical stability issue where grabber would exhaust DRM resources and cause Kodi video playback failures. Kodi now remains stable during video playback with grabber running.
- Fix GEM handle cleanup in dump_framebuffer_to_image() - Clean up ALL GEM handles, not just handles[0] - Add duplicate handle detection to avoid cleanup warnings - Update deployment script for LibreELEC compatibility Resolves critical stability issue where grabber would exhaust DRM resources and cause Kodi video playback failures. Kodi now remains stable during video playback with grabber running.
joopdo
changed the title
Author
|
drm-vc4-grabber.zip |
added 3 commits
December 10, 2025 15:13
Critical fix: Restore proper GEM handle cleanup in dump_framebuffer_to_image() Root cause analysis: - Branch switch via syncthing lost the working master branch structure - P030 format (4K content) had early return that bypassed cleanup entirely - GEM handles accumulated causing resource exhaustion and Kodi crashes Solution: - Restore master branch's closure-based cleanup approach - Use if/else structure instead of early returns - Ensure cleanup_handles() is ALWAYS called regardless of success/failure - Proper HashSet-based duplicate handle detection This restores the stability that was working before the branch sync issue. Fixes: Resource leaks in 4K content processing Prevents: Kodi crashes due to DRM handle exhaustion
Removed: - Temporary shell scripts (apply_*, commit_*, restore_*, setup_*) - Build artifacts (*.deb files) - Log files and temporary files - IDE configuration (.kiro/) - Build cache (.cargo/) Added comprehensive .gitignore to prevent future accidents. Keeps only essential project files: - Source code (src/) - Build configuration (Cargo.toml, build.sh, deploy.sh) - Documentation (README.md, LICENSE) - System integration (systemd/)
joopdo
force-pushed
the
feature/4k-detection-workaround
branch
from
6408b7f to
d1c8163
Compare
- Document compatibility with both Hyperion and HyperHDR - Explain shared TCP protocol and port (19400) - Clarify technical basis for cross-compatibility
Author
|
Seems stable for me. Closing #33 |
joopdo
changed the title
joopdo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.