Make precision calculation in bigdecimal.div(value, 0) gc-compaction safe #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompng
force-pushed
the
gc_compaction_safe_div
branch
from
075c642 to
64ac3f8
Compare
tompng
force-pushed
the
gc_compaction_safe_div
branch
from
64ac3f8 to
9b7db4b
Compare
…safe ((Real*)x)->obj, a reference from T_DATA to VALUE, will be garbled after gc compaction. We should avoid using x->obj as possible for now. It should be removed from struct Real in the future.
tompng
force-pushed
the
gc_compaction_safe_div
branch
from
9b7db4b to
3a3d50a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #337
((Real*)x)->obj, a reference from T_DATA to VALUE, will be garbled after gc compaction. We should avoid using x->obj as possible for now. It should be removed from struct Real in the future.