Specify nullability for drop-in compatibility from Swift #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change SDAVAssetExportSession was not actually a drop-in replacement for AVAssetExportSession when called from Swift. One concession is that the initializer return values are nullable even though we don't ever return nil, purely for compatibility with AVAssetExportSession.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change SDAVAssetExportSession was not actually a drop-in replacement for AVAssetExportSession when called from Swift.
One concession I made is that the initializer return values are nullable even though we don't ever return nil, purely for compatibility with AVAssetExportSession. Given other differences in the initializer method signature maybe this isn't the right call. It's certainly open to debate.