Refactoring Juicebox GCP Service #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesBelchamber
force-pushed
the
refactor-juicebox-service
branch
from
b460718 to
fb7aa0b
Compare
JamesBelchamber
force-pushed
the
refactor-juicebox-service
branch
2 times, most recently
from
0c3c473 to
03f8b2a
Compare
JamesBelchamber
force-pushed
the
refactor-juicebox-service
branch
from
03f8b2a to
c24226b
Compare
…f one is not provided
lazzurs
approved these changes
Jun 18, 2025
lazzurs
approved these changes
Jun 19, 2025
JamesBelchamber
pushed a commit
that referenced
this pull request
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a couple of things:
jb-sw-realmexecutable (removing the OpenTelemetry Collector and supervisord)mainIn the last PR (#2) we refactored the GCP Tofu to deploy with Google Cloud Run (instead of App Engine Flex), which is what we do internally anyway.
Note that the CI fails because of a legitimate issue but it's not concerning code in this PR; we will push a fix to this in a future PR.