Skip to content

Refactor: replace if-else chain with switch in db.go (gocritic ifElseChain) #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miladev95 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor: replace if-else chain with switch in db.go (gocritic ifElseChain) #334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions db.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,7 +695,8 @@ func (db *DB) loadIndexFromWAL() error {

// if we get the end of a batch,
// all records in this batch are ready to be indexed.
if record.Type == LogRecordBatchFinished {
switch record.Type {
case LogRecordBatchFinished:
batchId, err := snowflake.ParseBytes(record.Key)
if err != nil {
return err
Expand All @@ -710,12 +711,18 @@ func (db *DB) loadIndexFromWAL() error {
}
// delete indexRecords according to batchId after indexing
delete(indexRecords, uint64(batchId))
} else if record.Type == LogRecordNormal && record.BatchId == mergeFinishedBatchID {

case LogRecordNormal:
// if the record is a normal record and the batch id is 0,
// it means that the record is involved in the merge operation.
// so put the record into index directly.
db.index.Put(record.Key, position)
} else {
if record.BatchId == mergeFinishedBatchID {
db.index.Put(record.Key, position)
break
}
fallthrough

default:
// expired records should not be indexed
if record.IsExpired(now) {
db.index.Delete(record.Key)
Expand Down