-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[ntuple] Support creating ntuples within directories in RNTupleImporter #18966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results 19 files 19 suites 3d 9h 43m 42s ⏱️ Results for commit 351935f. ♻️ This comment has been updated with latest results. |
|
thanks for these changes. Is it easy to add a test? |
|
very nice. Thanks. |
a9a87b3 to
3a69a29
Compare
silverweed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Maybe wait for @enirolf's approval since she's the author of the RNTupleImporter
enirolf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the author but I can still give my review :). Functionality looks good! I think it could benefit from some documentation but after that should be good to go.
enirolf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This Pull request:
Changes or fixes:
This PR extends the functionality of the
RNTupleImporterto allow creating ntuples within directories in the destination file during the conversion.-> This would create the directory
Tupleif it doesn't already exists in the destination file and place the ntupleDecayTreeinside it.Checklist:
This PR fixes #18965