Skip to content

Raise when both query string and document are provided to Query #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 18, 2017
Merged

Raise when both query string and document are provided to Query #957

merged 3 commits into from
Sep 18, 2017

Conversation

xuorig
Copy link
Contributor

@xuorig xuorig commented Sep 17, 2017

As reported in #956

This PR does the quick fix to avoid the inconsistency in GraphQL::Query at runtime to avoid breaking changes.

@xuorig xuorig changed the title Raise query string and document Raise when both query string and document are provided to Query Sep 17, 2017
@rmosolgo rmosolgo added this to the 1.7.0 milestone Sep 18, 2017
@rmosolgo rmosolgo merged commit e3b2e05 into rmosolgo:master Sep 18, 2017
@rmosolgo
Copy link
Owner

👌 Thanks for the test, I'll try not to break it this time! 😬

@rmosolgo rmosolgo mentioned this pull request Nov 2, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@xuorig @rmosolgo