Skip to content

Conversation

@ThomasFarstrike
Copy link
Contributor

@ThomasFarstrike ThomasFarstrike commented Mar 6, 2025

This works fine for me, using the Arduino IDE (1.8.13) on Linux.

I don't see any conflict, but I did notice that esp-idf 5.3.2 has these 2 files called hash.h:

./esp-idf_5.3.2/components/mbedtls/mbedtls/tests/include/test/drivers/hash.h
./esp-idf_5.3.2/components/openthread/openthread/third_party/mbedtls/repo/tests/include/test/drivers/hash.h

They're lowercase hash.h, so (at least on Linux and MacOS) that's different from the Hash.h in uBitcoin.

I doubt these would conflict, even on Windows, but if you have any issues, please me know and then we can look for another solution :-)

Thank you!

@ThomasFarstrike ThomasFarstrike changed the title Make u bitcoin a dependency Make uBitcoin a dependency Mar 6, 2025
@riccardobl
Copy link
Owner

Just to be clear, the issues i was referring to were related to ports to non esp platforms.
I believe picow, but i had other issues in porting the library there that makes it basically unsupported atm.
So i will merge this PR for now, since it makes things easier for esp32.

Thank you.

@riccardobl riccardobl merged commit 21ebb18 into riccardobl:master Mar 7, 2025
@ThomasFarstrike
Copy link
Contributor Author

Sweet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants