-
Notifications
You must be signed in to change notification settings - Fork 42
Sender plugin: Pubsub #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Sender plugin: Pubsub #853
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #853 +/- ##
==========================================
+ Coverage 52.51% 52.53% +0.02%
==========================================
Files 133 133
Lines 13281 13289 +8
==========================================
+ Hits 6974 6981 +7
Misses 5762 5762
- Partials 545 546 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Once again thank you so much @muhammad-asghar-ali! This is going to help a lot, we actually want to move these plugins (pubsub, nats, sqs) into separate repos/packages to keep the dependencies in core resonate light. I am going to look into how core resonate can import stuff dynamically, once I figure that out would be down to move the pubsub and nats PRs to independent repos? I can create those repos and then you can open up PRs. |
Thanks for reviewing the PR and please let me know once you setup the independent repo |
|
Hey @muhammad-asghar-ali, we have decided to hold off on merging additional plugins until we have the chance to implement #886. Would it be possible for you to separate the generic base from the pubsub implementation? If so we could merge the generic base (and apply it poll, http, and sqs) right away, and only the pubsub implementation would be delayed until we have the plugin architecture in place. |
Hey @dfarr thanks for reviewing, and yes we can separate the generic base from pubsub and also conversation of http, poll and sqs. |
1.23to1.24to support pubsub v2 dependencyaio,workers,queues,metrics,start/stopmoved to baseProcess()method for their specific work