-
Notifications
You must be signed in to change notification settings - Fork 42
Sender plugin: Nats #846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Sender plugin: Nats #846
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #846 +/- ##
==========================================
+ Coverage 52.51% 52.52% +0.01%
==========================================
Files 133 133
Lines 13281 13290 +9
==========================================
+ Hits 6974 6981 +7
- Misses 5762 5763 +1
- Partials 545 546 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dfarr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much @muhammad-asghar-ali you are on fire!
… simpler code path
|
Sorry for the delay in getting back to you @muhammad-asghar-ali. I finally got around to testing this out (and learning more about nats). I noticed that we can specify the nats server host in the address, but we don't use it because the connection is created once at server startup and therefore we need to know the url of the nats server at this time. I think this is a fine, even a preferable, setup. But it does make the host part of the uri misleading. I wonder if for the time being we only specify uris like |
Thanks for reviewing, I'll look into your suggestion and share the solution with you |
You're right, |
|
Hey @muhammad-asghar-ali, we have decided to hold on off on additional plugins until we have a plugin architecture in place (see #886). Let's leave this PR as is for now and we will let you know when the new architecture is ready and we can then port this PR to the new design. |
1a7b409 to
578cdfa
Compare
|
Hey @dfarr need some guidance on github workflow failing, the error says Basically, Go is complaining that my So the solution is to update the Process method on Once the method signature matches, |
1787e77 to
d4015c1
Compare
8d5384e to
d4015c1
Compare
|
Hey @muhammad-asghar-ali I think you could rebase this PR on the current head of main and then you should see the compilation errors locally. If you can fix those and push we should be good to go! |
I merge the main with this feature branch
|

feat(plugin): add prototype NATS.io plugin for sender subsystem
Key new changes include:
cmd/plugin_nats.goto register the NATS plugin.go.modto include NATS dependencies.internal/app/plugins/nats)and the NATS API subsystem (
internal/app/subsystems/api/nats).operations (promises, schedules, locks, tasks).
nats://scheme.