12.0.0-alpha.13: Pervasives not found when using pnpm

[hackwaly]

version: 12.0.0-alpha.13
platform: macOS arm64

demo https://gist.github.com/hackwaly/bae3945b92170e79b9130bf1b6019209

pnpm rewatch watch
[1/7] 📦 Built package tree in 0.00s
[2/7] 👀 Found source files in 0.00s
[3/7] 📝 Read compile state 0.00s
[4/7] 🧹 Cleaned 0/2 0.00s
[5/7] 🧱 Parsed 0 source files in 0.00s
[6/7] 🌴 Collected deps in 0.00s
[7/7] ❌ Compiled 2 modules in 0.01s

  We've found a bug for you!
  command line

  The module or file Pervasives can't be found.
  - If it's a third-party dependency:
    - Did you add it to the "bs-dependencies" or "bs-dev-dependencies" in rescript.json?
  - Did you include the file's directory to the "sources" in rescript.json?
  


  We've found a bug for you!
  command line

  The module or file Pervasives can't be found.
  - If it's a third-party dependency:
    - Did you add it to the "bs-dependencies" or "bs-dev-dependencies" in rescript.json?
  - Did you include the file's directory to the "sources" in rescript.json?

Thank you for filing! Check list:

• Is it a bug? Usage questions should often be asked in the forum instead.
• Concise, focused, friendly issue title & description.
• A minimal, reproducible example.
• OS and browser versions, if relevant.
• Is it already fixed in master? Instructions

[nojaf]

Thanks for reporting this. I can reproduce this.
Both rewatch and bsb can't find Pervasives.src.
I believe this is related to pnpm.

[hackwaly]

I believe the root cause is here:

rescript/rewatch/src/build/compile.rs

Lines 474 to 477 in a375a47

	vec![
	"-I".to_string(),
	Path::new("..").join("ocaml").to_string_lossy().to_string(),
	],

It wrongly assumed that include_dir is just "../ocaml".

I think we should change this

rescript/cli/rewatch.js

Line 10 in a375a47

child_process.spawnSync(rewatch_exe, [...args, "--bsc-path", bsc_exe], {

to pass the "--rescript-home" dir to rewatch, and let rewatch to use that to generate argument of -I, as we split rescript bin to dedicated package.

FYI:

rescript/rewatch/src/build/compile.rs

Lines 490 to 493 in a375a47

	// vec![
	// "-I".to_string(),
	// abs_node_modules_path.to_string() + "/rescript/ocaml",
	// ],

[nojaf]

Thanks for doing some investigation here @hackwaly!
@jfrolich any thoughts?

[jfrolich]

@hackwaly that is the path of the compiler assets fo the current package, for the dependencies we use an absolute path based on the node modules directory. The pervasive module is the standard library and that is something the compiler always includes (and is included by the compiler not by the build system). Are you sure it works in bsb. Otherwise we have to fix it in the compiler.

[hackwaly]

I'm sure it not works with bsb.