rescript@11.0.0-alpha.3 The @inline attribute doesn't work in uncurried mode.

[DZakh]

Example:

@inline
let inlined = () => ()

[cristianoc]

I'm not sure how inline is supposed to work in this case.
Perhaps it still applies, or perhaps there are some difficulties.
Needs investigating.

[cristianoc]

So this has never worked:

@inline
let inlined = (. ) => ()

so strictly speaking here we're talking about an extension of functionality.

[DZakh]

I run the benchmarks for rescript-struct with uncurried mode on and broken @inline attribute. The result was pretty much the same.

[DZakh]

So, it's not as critical as I though, but it still would be nice to have it working in uncurried mode.

[cristianoc]

@DZakh take a look here: #6152
I've simply turned off the warning. One would need to still test that inline behaves as expected. Would you check that?

[DZakh]

Yep, but only tomorrow

[cristianoc]

Yep, but only tomorrow

Sounds good. I'll leave this here.

[cristianoc]

I looked a bit at @inline in general. Not really clear what it does except for constants defined locally.
For functions, inlining seems to happen pretty much automatically, and I don't know how much @inline affects that at all.
What might be useful, is to take the existing code, before trying to switch to the new compiler, and remove all the @inline see if it ever made a difference.