Skip to content

Update: Next 15, React 19, ReScript 12.0.0-alpha.14, ReScript/React 0… #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 23, 2025

Conversation

aspeddro
Copy link
Collaborator

@aspeddro aspeddro commented Jun 22, 2025

….14.0-rc.1

I started working on #1037 using the webapi package but it requires rescript ^12.0.0-alpha.13 and several updates, so I made this PR

@aspeddro aspeddro self-assigned this Jun 22, 2025
Copy link

vercel bot commented Jun 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rescript-lang.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2025 3:23am

Copy link

cloudflare-workers-and-pages bot commented Jun 22, 2025

Deploying rescript-lang-org with  Cloudflare Pages  Cloudflare Pages

Latest commit: 70ecb2d
Status: ✅  Deploy successful!
Preview URL: https://9063d85a.rescript-lang.pages.dev
Branch Preview URL: https://local-storage-version.rescript-lang.pages.dev

View logs

@@ -72,6 +72,7 @@
"cssnano": "^6.0.1",
"dotenv": "^16.4.7",
"esbuild-loader": "^4.3.0",
"jsdom": "^26.1.0",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The jsdom dependency was not added in #980

@@ -1,4 +1,4 @@
# Overview
# Introduction
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming to keep consistent with the language manual

master
image

api page on master
image

This pr changes
image

@aspeddro aspeddro marked this pull request as ready for review June 23, 2025 03:12
@@ -258,8 +257,7 @@ module Toggle = {
<div className="relative pt-6 w-full rounded-none text-gray-80">
//text within code-box
<div
className="absolute flex w-full font-sans bg-transparent text-14 text-gray-40 "
style={ReactDOM.Style.make(~marginTop="-26px", ())}>
className="absolute flex w-full font-sans bg-transparent text-14 text-gray-40 mt-[-26px] overflow-x-auto">
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enable overflow on code example tabs

image

Copy link
Member

@tsnobip tsnobip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work @aspeddro!

| Some(m) => m
| None => "Unknown error"
}
\"@@"(raise, ParseError(message))
throw(ParseError(message))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually wondering if we should keep this outdated Json encoder/decoder vendored lib, using plain rescript should be much better now that we even have pattern matching on dict with v12! But this could be part of another PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

def. stuff for another PR

@tsnobip
Copy link
Member

tsnobip commented Jun 23, 2025

the two things I'd love to update next would be CodeMirror to v6 and use app router in next to handle URL searches correctly!

@fhammerschmidt
Copy link
Member

TYSM!

@fhammerschmidt fhammerschmidt merged commit c72e414 into master Jun 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants