-
-
Notifications
You must be signed in to change notification settings - Fork 252
Update: Next 15, React 19, ReScript 12.0.0-alpha.14, ReScript/React 0… #1058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deploying rescript-lang-org with
|
Latest commit: |
70ecb2d
|
Status: | ✅ Deploy successful! |
Preview URL: | https://9063d85a.rescript-lang.pages.dev |
Branch Preview URL: | https://local-storage-version.rescript-lang.pages.dev |
@@ -72,6 +72,7 @@ | |||
"cssnano": "^6.0.1", | |||
"dotenv": "^16.4.7", | |||
"esbuild-loader": "^4.3.0", | |||
"jsdom": "^26.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The jsdom
dependency was not added in #980
@@ -1,4 +1,4 @@ | |||
# Overview | |||
# Introduction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -258,8 +257,7 @@ module Toggle = { | |||
<div className="relative pt-6 w-full rounded-none text-gray-80"> | |||
//text within code-box | |||
<div | |||
className="absolute flex w-full font-sans bg-transparent text-14 text-gray-40 " | |||
style={ReactDOM.Style.make(~marginTop="-26px", ())}> | |||
className="absolute flex w-full font-sans bg-transparent text-14 text-gray-40 mt-[-26px] overflow-x-auto"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work @aspeddro!
| Some(m) => m | ||
| None => "Unknown error" | ||
} | ||
\"@@"(raise, ParseError(message)) | ||
throw(ParseError(message)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm actually wondering if we should keep this outdated Json encoder/decoder vendored lib, using plain rescript should be much better now that we even have pattern matching on dict with v12! But this could be part of another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def. stuff for another PR
the two things I'd love to update next would be CodeMirror to v6 and use app router in next to handle URL searches correctly! |
TYSM! |
….14.0-rc.1
I started working on #1037 using the webapi package but it requires rescript ^12.0.0-alpha.13 and several updates, so I made this PR