Skip to content

Conversation

Copy link
Contributor

@JonathanHuot JonathanHuot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonathanHuot JonathanHuot added this to the 1.3.1 milestone Nov 2, 2021
Copy link
Contributor

@jtroussard jtroussard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With regards to making updates to the example files, can we introduce a new contribution requirement to include some sort of verification?

@likesclever
Copy link
Contributor Author

likesclever commented Nov 12, 2021

Do i need to do anything else

Is there a way to verify these changes work? Screen shot, demo, or something else maybe?

@likesclever
Copy link
Contributor Author

Do i need to do anything else

Is there a way to verify these changes work? Screen shot, demo, or something else maybe?

Without "openid", the "email" attribute is not returned:
{'id': '102430716320508450299', 'name': '王健辉', 'given_name': '健辉', 'family_name': '王', 'picture': 'https://lh3.googleusercontent.com/a-/AOh14GgIPx4ZiXyy-rEPCQu9ARptOQmXar2qwh1RIcqy=s96-c', 'locale': 'zh-CN'}
After adding "openid", the "email" attribute will be returned:
{'id': '102430716320508450299', 'email': '[email protected]', 'verified_email': True, 'name': '王健辉', 'given_name': '健辉', 'family_name': '王', 'picture': 'https://lh3.googleusercontent.com/a-/AOh14GgIPx4ZiXyy-rEPCQu9ARptOQmXar2qwh1RIcqy=s96-c', 'locale': 'zh-CN'}

@jtroussard
Copy link
Contributor

Do i need to do anything else

Is there a way to verify these changes work? Screen shot, demo, or something else maybe?

Without "openid", the "email" attribute is not returned: {'id': '102430716320508450299', 'name': '王健辉', 'given_name': '健辉', 'family_name': '王', 'picture': 'https://lh3.googleusercontent.com/a-/AOh14GgIPx4ZiXyy-rEPCQu9ARptOQmXar2qwh1RIcqy=s96-c', 'locale': 'zh-CN'} After adding "openid", the "email" attribute will be returned: {'id': '102430716320508450299', 'email': '[email protected]', 'verified_email': True, 'name': '王健辉', 'given_name': '健辉', 'family_name': '王', 'picture': 'https://lh3.googleusercontent.com/a-/AOh14GgIPx4ZiXyy-rEPCQu9ARptOQmXar2qwh1RIcqy=s96-c', 'locale': 'zh-CN'}

was the example broken before?

@jtroussard
Copy link
Contributor

jtroussard commented Jan 1, 2022

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 90.239% when pulling e92087f on mrwangjianhui:Update-google.rst into 46f886c on requests:master.

Copy link
Contributor

@jtroussard jtroussard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jtroussard jtroussard merged commit 00e8156 into requests:master Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants