Skip to content

fix(redis)!: add default auth to redis clusters #37337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jamietanna merged 1 commit into from
Nov 5, 2025
Merged

fix(redis)!: add default auth to redis clusters #37337

jamietanna merged 1 commit into from
Nov 5, 2025

Conversation

@jaylindquist
Copy link
Contributor

@jaylindquist jaylindquist commented Aug 5, 2025

Changes

Using redis in a cluster with authentication causes the following error:

WARN: Error while setting Redis cache value (repository=/)
"err": {"message": "NOAUTH Authentication required."}

This change adds the username and password from the redis URL as defaults for connections to non-root node servers as described in the node redis docs

Context

Logs and motivation in #37319

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

rarkins
rarkins previously requested changes Aug 5, 2025
View reviewed changes
@jaylindquist jaylindquist requested a review from rarkins August 5, 2025 20:49
rarkins
rarkins reviewed Aug 5, 2025
View reviewed changes
Copy link
Contributor

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need some time to check with some known users of cluster mode to confirm that none of them are using username/password. If they are, then we need to reconfirm the assumptions which lead to this PR

@rarkins rarkins added the auto:no-merge-from-main Advise contributors not to merge from main unnecessarily label Aug 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

Hi there,

Please don't merge from main into your PR's branch unless you have a merge conflict or have a specific reason to do so. Doing so consumes CI systems unnecessarily, and also resets CI approvals if this is your first PR to the repo. This repo uses GitHub's Merge Queue, which will automatically test your PR against main before merging, so it's no longer necessary to always keep branches up-to-date.

Thanks,

The Renovate team

viceice
viceice reviewed Aug 14, 2025
View reviewed changes
@viceice viceice added this to the v42 milestone Aug 15, 2025
@jaylindquist
Copy link
Contributor Author

jaylindquist commented Sep 2, 2025

@rarkins are their any updates from customers?

@viceice viceice requested a review from jamietanna October 16, 2025 11:34
@jamietanna
Copy link
Contributor

jamietanna commented Oct 16, 2025

(I've raised this internally at Mend, thanks for your patience!)

@jamietanna jamietanna self-assigned this Oct 16, 2025
@jamietanna jamietanna removed the auto:no-merge-from-main Advise contributors not to merge from main unnecessarily label Oct 16, 2025
@jamietanna jamietanna added the breaking Breaking change, requires major version bump label Oct 24, 2025
@jamietanna jamietanna changed the title fix(redis): add default auth to redis clusters fix(redis)!: add default auth to redis clusters Oct 24, 2025
@jamietanna
Copy link
Contributor

jamietanna commented Oct 31, 2025

To confirm, as far as we're aware, @jaylindquist y'all are the main folks impacted by this 🤓

This is planned to land in the coming CLI 42 release this coming week - I'll get the branch updated

@jamietanna
Copy link
Contributor

jamietanna commented Nov 4, 2025

Working through the follow-on from the major release #36423

@jamietanna jamietanna force-pushed the fix/redis-cluster-auth branch from 0e91f3d to 3e87498 Compare November 4, 2025 09:33
jamietanna
jamietanna reviewed Nov 4, 2025
View reviewed changes
@viceice viceice dismissed rarkins’s stale review November 4, 2025 09:44

no longer maintainer

@jaylindquist @jamietanna
fix(redis)!: add default auth to redis clusters
245a349 
When using Redis in a cluster with authentication, we see errors
connecting to non-root nodes with:

  WARN: Error while setting Redis cache value (repository=<org>/<repo>)
        "err": {"message": "NOAUTH Authentication required."}

This change adds the username and password from the redis URL as
defaults for connections to non-root node servers as described in the
node-redis docs[0].

Co-authored-by: Michael Kriese <[email protected]>

[0]: https://github.com/redis/node-redis/blob/master/docs/clustering.md#auth-with-password-and-username
@jamietanna jamietanna force-pushed the fix/redis-cluster-auth branch from 93df76e to 245a349 Compare November 4, 2025 09:49
@jamietanna jamietanna changed the base branch from main to next-major November 5, 2025 11:31
@jamietanna jamietanna merged commit 8a1df20 into renovatebot:next-major Nov 5, 2025
39 checks passed
jamietanna pushed a commit that referenced this pull request Nov 5, 2025
@jaylindquist @jamietanna
fix(redis)!: add default auth to redis clusters (#37337)
5c22efc 
When using Redis in a cluster with authentication, we see errors
connecting to non-root nodes with:

  WARN: Error while setting Redis cache value (repository=<org>/<repo>)
        "err": {"message": "NOAUTH Authentication required."}

This change adds the username and password from the redis URL as
defaults for connections to non-root node servers as described in the
node-redis docs[0].

Co-authored-by: Michael Kriese <[email protected]>

[0]: https://github.com/redis/node-redis/blob/master/docs/clustering.md#auth-with-password-and-username
jamietanna pushed a commit that referenced this pull request Nov 5, 2025
@jaylindquist @jamietanna
fix(redis)!: add default auth to redis clusters (#37337)
d2cad9e 
When using Redis in a cluster with authentication, we see errors
connecting to non-root nodes with:

  WARN: Error while setting Redis cache value (repository=<org>/<repo>)
        "err": {"message": "NOAUTH Authentication required."}

This change adds the username and password from the redis URL as
defaults for connections to non-root node servers as described in the
node-redis docs[0].

Co-authored-by: Michael Kriese <[email protected]>

[0]: https://github.com/redis/node-redis/blob/master/docs/clustering.md#auth-with-password-and-username
jamietanna pushed a commit that referenced this pull request Nov 5, 2025
@jaylindquist @jamietanna
fix(redis)!: add default auth to redis clusters (#37337)
308804b 
When using Redis in a cluster with authentication, we see errors
connecting to non-root nodes with:

  WARN: Error while setting Redis cache value (repository=<org>/<repo>)
        "err": {"message": "NOAUTH Authentication required."}

This change adds the username and password from the redis URL as
defaults for connections to non-root node servers as described in the
node-redis docs[0].

Co-authored-by: Michael Kriese <[email protected]>

[0]: https://github.com/redis/node-redis/blob/master/docs/clustering.md#auth-with-password-and-username
jamietanna pushed a commit that referenced this pull request Nov 6, 2025
@jaylindquist @jamietanna
fix(redis)!: add default auth to redis clusters (#37337)
df9844d 
When using Redis in a cluster with authentication, we see errors
connecting to non-root nodes with:

  WARN: Error while setting Redis cache value (repository=<org>/<repo>)
        "err": {"message": "NOAUTH Authentication required."}

This change adds the username and password from the redis URL as
defaults for connections to non-root node servers as described in the
node-redis docs[0].

Co-authored-by: Michael Kriese <[email protected]>

[0]: https://github.com/redis/node-redis/blob/master/docs/clustering.md#auth-with-password-and-username
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@viceice viceice viceice approved these changes

@jamietanna jamietanna jamietanna approved these changes

@nabeelsaabna nabeelsaabna Awaiting requested review from nabeelsaabna

+3 more reviewers

@rarkins rarkins rarkins left review comments

@astellingwerf astellingwerf astellingwerf approved these changes

@Cassieminkus1 Cassieminkus1 Cassieminkus1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jamietanna jamietanna

Labels

breaking Breaking change, requires major version bump

Projects

None yet

Milestone

v42

Development

Successfully merging this pull request may close these issues.

7 participants

@jaylindquist @jamietanna @astellingwerf @viceice @rarkins @nabeelsaabna @Cassieminkus1