Skip to content

fix(ci): Skip docker dry-run for pull requests #36372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Jun 7, 2025

Changes

The build-docker is the disproportionally longest job which is unlikely to break when the non-Docker functionality is being changed in the PR.

This PR delays dry-run step to later stage (e.g. merge queue), which saves one minute for ordinary PRs check time and makes jobs timing uniform.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov
Copy link
Collaborator Author

zharinov commented Jun 7, 2025

It's still the longest check. Maybe we could skip it completely in PRs? It would make PR checks finish twice faster.

@zharinov zharinov requested review from viceice and rarkins June 7, 2025 13:14
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remember this recently catched null pointer errors which were not detected by unit tests.

@zharinov
Copy link
Collaborator Author

zharinov commented Jun 7, 2025

remember this recently catched null pointer errors which were not detected by unit tests.

I don't know about it, but maybe still it's okay to catch things like that at the merge queue stage, in exchange for faster CI for more typical PRs

@rarkins rarkins added this pull request to the merge queue Jun 9, 2025
Merged via the queue into renovatebot:main with commit 4452879 Jun 9, 2025
40 checks passed
@rarkins rarkins deleted the fix/docker-skip-dry-run-for-pull-requests branch June 9, 2025 13:01
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 40.48.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants