-
Notifications
You must be signed in to change notification settings - Fork 21
fix(ui): Tooltip - revert dark background #5109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe tooltip component's CSS was updated to invert its color scheme. The background color now uses the text color variable, and the text color uses the background color variable. Additionally, the SVG arrow's fill color has been changed from a highlight color to the text color variable. These modifications affect only the visual appearance of the tooltip and do not impact its structure or behavior. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/ui/src/ui/tooltip/tooltip.module.css (1)
17-19: Accessibility & maintainability: verify contrast and refine property usage
Changing.tooltipto usebackground: var(--color-text)withcolor: var(--color-background)inverts the scheme and may impact readability.
- Ensure this combination meets WCAG 2.1 AA contrast requirements across light/dark themes.
- Prefer the more specific
background-colorproperty to avoid unintentionally overriding other background settings:- background: var(--color-text); + background-color: var(--color-text);
- Optionally, introduce dedicated tooltip variables (e.g.
--tooltip-bg,--tooltip-text) to decouple from global tokens and simplify future theming.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/ui/src/ui/tooltip/tooltip.module.css(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: build
- GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
packages/ui/src/ui/tooltip/tooltip.module.css (1)
28-28: Arrow fill aligns with background
Usingfill: var(--color-text)for the SVG arrow correctly matches the tooltip’s background color, preserving visual consistency.
#12124 Bundle Size — 382.12KiB (~-0.01%).1a24557(current) vs cec72db master#12122(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
Bundle analysis report Branch fix-tooltips Project dashboard Generated by RelativeCI Documentation Report issue |
Summary by CodeRabbit